S4MK3 & S3: Performance MOD (qml coding)

Since the pad modes are qml coded, it will be difficult to map them with the controller manager. I'll have a look at @pixel 's S3 code to see if the is a problem with prioritizing stem over lower deck remix controls using SAMPLE mode. Can you check if it works when deck C and D are track decks instead of remix decks?

I just checked the code, both the original of TP3.11.1 and TP4 as well as the mod's code, which is based on 3.11.1.

TP3 code doesn't have the stem pad mode switch in it at all, although the files to actually control stems are there. I don't know how this came to be (i don't own an S3 or i would have encountered this earlier). But i can see what code in which files needs to get updated.

I can adjust the code for you (it's only two files as far as i can see), but i can't test, so you will need to do the testing. You up for it?

@DJ ALX

Take it for a spin. Same changes as before, this time on V10.2.

I have the fx sends already in the S4 mod. I was hoping @pixel would do the updates to the S3 mod, since he has one at home. And since your request was something readily accesible (i was working on those codes recently and knew exactly what to do) i picked up the slack. I don't prefer working on controllers i don't own in my free time.

If you like the fiddling, i can post the code i want to publish after the next traktor release in my next mod update that concerns the stem mute pads (blinking instead of dimming for better feedback) if you like. You can pretty much insert it in the file you just edited for it to work.

Edit: I can check for code formatting in the qml files for the layout/browser assignments.

'S3Stems.qml'

At the top add this line so that the blink code works.

import QtQuick 2.12

If you want to have the encoders be a bit more precise with volume/filter, adjust the value like i did (original code commented out with '//'). I found 0.05 to be too coarse for the filter.

// StemDeckStreams { name: "stems"; channel: deckIdx; encoderStep: 0.05 }
StemDeckStreams { name: "stems"; channel: deckIdx; encoderStep: 0.025 }

Right under the MappingPropertyDescriptor add the following lines.

AppProperty { id: stemColorId_1;  path: "app.traktor.decks." + deckIdx + ".stems.1.color_id" }
AppProperty { id: stemColorId_2;  path: "app.traktor.decks." + deckIdx + ".stems.2.color_id" }
AppProperty { id: stemColorId_3;  path: "app.traktor.decks." + deckIdx + ".stems.3.color_id" }
AppProperty { id: stemColorId_4;  path: "app.traktor.decks." + deckIdx + ".stems.4.color_id" }

AppProperty { id: stemMuted_1;  path: "app.traktor.decks." + deckIdx + ".stems.1.muted" }
AppProperty { id: stemMuted_2;  path: "app.traktor.decks." + deckIdx + ".stems.2.muted" }
AppProperty { id: stemMuted_3;  path: "app.traktor.decks." + deckIdx + ".stems.3.muted" }
AppProperty { id: stemMuted_4;  path: "app.traktor.decks." + deckIdx + ".stems.4.muted" }

//PAD should BLINK when STEM is MUTED
Timer {
  id: stemMuteBlinkTimer
  property bool  blink: false
  interval: 500

  repeat: true
  running: stemMuted_1.value || stemMuted_2.value || stemMuted_3.value || stemMuted_4.value
  onTriggered: {
    blink = !blink;
  }
}

The next piece of code is for the pads:

Right under this …

WiresGroup
{
  enabled: active

… place the following code that is basically replacing the code you posted above. It will also have a reset button for each stem's volume/mute/filter values at the shifted layer of the top 4 pads (in white). The FX send buttons (shifted layer bottom row) are in orange.

WiresGroup
{
  enabled: !module.shift

  //----------------------- Top Pads to stem mutes LED -----------------------------

  Wire { from: "%surface%.pads.1"; to: ButtonScriptAdapter { brightness: stemMuteBlinkTimer.blink; color: stemColorId_1.value;} enabled: stemMuted_1.value }
  Wire { from: "%surface%.pads.2"; to: ButtonScriptAdapter { brightness: stemMuteBlinkTimer.blink; color: stemColorId_2.value;} enabled: stemMuted_2.value }
  Wire { from: "%surface%.pads.3"; to: ButtonScriptAdapter { brightness: stemMuteBlinkTimer.blink; color: stemColorId_3.value;} enabled: stemMuted_3.value }
  Wire { from: "%surface%.pads.4"; to: ButtonScriptAdapter { brightness: stemMuteBlinkTimer.blink; color: stemColorId_4.value;} enabled: stemMuted_4.value }

  //----------------------- Top Pads to stem mutes VALUE -----------------------------
   
  Wire { from: "%surface%.pads.1.value"; to: "stems.1.muted"; enabled: stemMuted_1.value }
  Wire { from: "%surface%.pads.2.value"; to: "stems.2.muted"; enabled: stemMuted_2.value }
  Wire { from: "%surface%.pads.3.value"; to: "stems.3.muted"; enabled: stemMuted_3.value }
  Wire { from: "%surface%.pads.4.value"; to: "stems.4.muted"; enabled: stemMuted_4.value }

  Wire { from: "%surface%.pads.1"; to: "stems.1.muted"; enabled: !stemMuted_1.value }
  Wire { from: "%surface%.pads.2"; to: "stems.2.muted"; enabled: !stemMuted_2.value }
  Wire { from: "%surface%.pads.3"; to: "stems.3.muted"; enabled: !stemMuted_3.value }
  Wire { from: "%surface%.pads.4"; to: "stems.4.muted"; enabled: !stemMuted_4.value }
 

  //------------------------- Lower pads to stem focus ---------------------------

  Wire { from: "%surface%.pads.5"; to: HoldPropertyAdapter { path: deckPropertiesPath + ".stems.active_stem"; value: 1; defaultValue: 0 } }
  Wire { from: "%surface%.pads.6"; to: HoldPropertyAdapter { path: deckPropertiesPath + ".stems.active_stem"; value: 2; defaultValue: 0 } }
  Wire { from: "%surface%.pads.7"; to: HoldPropertyAdapter { path: deckPropertiesPath + ".stems.active_stem"; value: 3; defaultValue: 0 } }
  Wire { from: "%surface%.pads.8"; to: HoldPropertyAdapter { path: deckPropertiesPath + ".stems.active_stem"; value: 4; defaultValue: 0 } }
}

WiresGroup
{
  enabled: module.shift
  
  //---------------- Top pads to reset stem mute, volume and filter -------------

  Wire { from: "%surface%.pads.1"; to: SetPropertyAdapter { path: "app.traktor.decks." + deckIdx + ".stems.1.muted"; value: false } }
  Wire { from: "%surface%.pads.1"; to: SetPropertyAdapter { path: "app.traktor.decks." + deckIdx + ".stems.1.volume"; value: 1.0; output: false } }
  Wire { from: "%surface%.pads.1"; to: SetPropertyAdapter { path: "app.traktor.decks." + deckIdx + ".stems.1.filter_value"; value: 0.5; output: false } }
  Wire { from: "%surface%.pads.2"; to: SetPropertyAdapter { path: "app.traktor.decks." + deckIdx + ".stems.2.muted"; value: false } }
  Wire { from: "%surface%.pads.2"; to: SetPropertyAdapter { path: "app.traktor.decks." + deckIdx + ".stems.2.volume"; value: 1.0; output: false } }
  Wire { from: "%surface%.pads.2"; to: SetPropertyAdapter { path: "app.traktor.decks." + deckIdx + ".stems.2.filter_value"; value: 0.5; output: false } }
  Wire { from: "%surface%.pads.3"; to: SetPropertyAdapter { path: "app.traktor.decks." + deckIdx + ".stems.3.muted"; value: false } }
  Wire { from: "%surface%.pads.3"; to: SetPropertyAdapter { path: "app.traktor.decks." + deckIdx + ".stems.3.volume"; value: 1.0; output: false } }
  Wire { from: "%surface%.pads.3"; to: SetPropertyAdapter { path: "app.traktor.decks." + deckIdx + ".stems.3.filter_value"; value: 0.5; output: false } }
  Wire { from: "%surface%.pads.4"; to: SetPropertyAdapter { path: "app.traktor.decks." + deckIdx + ".stems.4.muted"; value: false } }
  Wire { from: "%surface%.pads.4"; to: SetPropertyAdapter { path: "app.traktor.decks." + deckIdx + ".stems.4.volume"; value: 1.0; output: false } }
  Wire { from: "%surface%.pads.4"; to: SetPropertyAdapter { path: "app.traktor.decks." + deckIdx + ".stems.4.filter_value"; value: 0.5; output: false } }

  //----------------------- Lower Pads to stem FX send -----------------------------
  
  Wire { from: "%surface%.pads.5"; to: "stems.1.fx_send_on" }
  Wire { from: "%surface%.pads.6"; to: "stems.2.fx_send_on" }
  Wire { from: "%surface%.pads.7"; to: "stems.3.fx_send_on" }
  Wire { from: "%surface%.pads.8"; to: "stems.4.fx_send_on" }

}

Have fun! :)

Can you test this file? I am curious what broke. It may be just a syntax error. If this one works you can compare it to your own file to see what's what:

If you just want to switch off the LED, you have to add this at the beginning of your working file (just in front of the first Wire or WiresGroup, it can't be inside):

AppProperty { id: stemMuted_1;  path: "app.traktor.decks." + deckIdx + ".stems.1.muted" }
AppProperty { id: stemMuted_2;  path: "app.traktor.decks." + deckIdx + ".stems.2.muted" }
AppProperty { id: stemMuted_3;  path: "app.traktor.decks." + deckIdx + ".stems.3.muted" }
AppProperty { id: stemMuted_4;  path: "app.traktor.decks." + deckIdx + ".stems.4.muted" }

Step two is to replace the four mute wires …

Wire { from: "%surface%.pads.1"; to: "stems.1.muted" }
Wire { from: "%surface%.pads.2"; to: "stems.2.muted" }
Wire { from: "%surface%.pads.3"; to: "stems.3.muted" }
Wire { from: "%surface%.pads.4"; to: "stems.4.muted" }

…with the following eight mute wires:

Wire { from: "%surface%.pads.1.value"; to: "stems.1.muted"; enabled: stemMuted_1.value }
Wire { from: "%surface%.pads.2.value"; to: "stems.2.muted"; enabled: stemMuted_2.value }
Wire { from: "%surface%.pads.3.value"; to: "stems.3.muted"; enabled: stemMuted_3.value }
Wire { from: "%surface%.pads.4.value"; to: "stems.4.muted"; enabled: stemMuted_4.value }

Wire { from: "%surface%.pads.1"; to: "stems.1.muted"; enabled: !stemMuted_1.value }
Wire { from: "%surface%.pads.2"; to: "stems.2.muted"; enabled: !stemMuted_2.value }
Wire { from: "%surface%.pads.3"; to: "stems.3.muted"; enabled: !stemMuted_3.value }
Wire { from: "%surface%.pads.4"; to: "stems.4.muted"; enabled: !stemMuted_4.value }

This will have the led output only be there if mute is off.