S4MK3 & S3: Performance MOD (qml coding)

Options
24567…19

Comments

  • Sûlherokhh
    Sûlherokhh Member, Traktor Mapping Mod Posts: 1,818 mod
    edited February 27
    Options

    What do you mean when you say 'after a track change'?

    How do you change tracks? Load when it's running? Load when it's in the process of breaking? Load when it is stopped?

    My guess is that the property does not get reset after changing. But it should reset when the break comes to an end.

    What happens when you add this?

      AppProperty { path: "app.traktor.decks." + deckIdx + ".is_loaded_signal";
    onValueChanged: {
      vinylBreak.value = false
      tempobend.value = 0
      if (previousKeyLockState) {
        keyLock.value = true
        previousKeyLockState = false
      }
      if (previousSyncState) {
        isSyncEnabled.value = true
        previousSyncState = false
      }
    }
  }

    Edit: This code works on my end, cutting off the tailend of the breakdown when i immediately load a track while breaking.

  • pixel
    pixel Member Posts: 114 Helper
    Options

    you are a genius, problem solved.

    I bow to you :)

  • Sûlherokhh
    Sûlherokhh Member, Traktor Mapping Mod Posts: 1,818 mod
    Options
    https://community.native-instruments.com/discussion/comment/136570#Comment_136570

    One more thing. I found a copy paste mistake of mine in the code.

    Look for this:

    ...
       if (previousKeyLockState) {
         keyLock.value = true
         previousKeyLockState = false
       }
       if (previousKeyLockState) {
         keyLock.value = true
         previousKeyLockState = false
       }
...

    Exchange it with this:

    ...
       if (previousKeyLockState) {
         keyLock.value = true
         previousKeyLockState = false
       }
       if (previousSyncState) {
         isSyncEnabled.value = true
         previousSyncState = false
       }
...


    ...

  • pixel
    pixel Member Posts: 114 Helper
    Options

    I have updated my upload.

    Conclusion after a week on the Traktor, it's just great^^

  • Sûlherokhh
    Sûlherokhh Member, Traktor Mapping Mod Posts: 1,818 mod
    Options

    Awesome. Enjoy spinning! 🎧

  • Sûlherokhh
    Sûlherokhh Member, Traktor Mapping Mod Posts: 1,818 mod
    Options

    Updated work in progress:

    • Setting manual LoopIn-/LoopOut points.
    • Adjusting LoopIn-/LoopOut points with the jog wheels.
    • Display LoopIn-/LoopOut points on the stripe, green colouring of the looping part of the waveform when the loop is active.
    • Browser scrolling with jog wheel.
    • FX presets/selection
    • Adding a screens-on/off toggle to reduce gfx workload for use with a pair of D2's.

    Next version will see a fix for a seldomly appearing bug with the VinylBreak when switching to a different track midway. Does anyone want a slowed VinylBuildUp function for starting the deck?

  • ErikMinekus
    ErikMinekus Member Posts: 38 Helper
    Options

    I noticed another mistake in onRelease:

           if (previousKeyLockState) {
         previousKeyLockState = true
       }

    Should be:

           if (previousKeyLockState) {
         keyLock.value = true
       }

    Nice job, I also got it to work on the D2 by removing calls to vinylBreak.value and replacing hapticTensionProp.value with a hardcoded value 🙂

  • pixel
    pixel Member Posts: 114 Helper
    Options

    I discovered another error

    in the software click the play button


    VID_20240228_132353.zip


  • Sûlherokhh
    Sûlherokhh Member, Traktor Mapping Mod Posts: 1,818 mod
    edited February 28
    Options
    https://community.native-instruments.com/discussion/comment/136654#Comment_136654

    thx for checking.

    https://community.native-instruments.com/discussion/comment/136699#Comment_136699

    i know. i'll post the fix later. good you tested it as well.

  • Sûlherokhh
    Sûlherokhh Member, Traktor Mapping Mod Posts: 1,818 mod
    Options

    Update to fix the VinylBreak:

    • Added KeylockSync-Transition functions to save some space with all the places it gets used.
    • Added VinylBreakExit when loading track and when activating PLAY using any signal source (other controller, Traktor, etc.)
    S4MK3_TP3.11.1_PerformanceMod_03.zip


  • pixel
    pixel Member Posts: 114 Helper
    Options

    I'll take a look at it later and get back to you

  • pixel
    pixel Member Posts: 114 Helper
    edited February 29
    Options

    Great, the Problem is solved, thank you for updating :) , i have take it in the S3 data and atech the files.


    S3.zip


  • pixel
    pixel Member Posts: 114 Helper
    Options

    I still had a mistake.

    I added another condition to JogWheel.


    from

     WiresGroup {
   enabled: !gridAdjustEnableProp.value && module.active
   Wire { from: "%surface%.jogwheel.rotation"; to: "turntable.rotation" }
   Wire { from: "%surface%.jogwheel.speed"; to: "turntable.speed" }
   Wire { from: "%surface%.jogwheel.touch"; to: "turntable.touch"; enabled: !jogMode.value }
   Wire { from: "%surface%.shift"; to: "turntable.shift" }

    to

     WiresGroup {
   enabled: !gridAdjustEnableProp.value && module.active && !browserFullScreenProp.value
   Wire { from: "%surface%.jogwheel.rotation"; to: "turntable.rotation" }
   Wire { from: "%surface%.jogwheel.speed"; to: "turntable.speed" }
   Wire { from: "%surface%.jogwheel.touch"; to: "turntable.touch"; enabled: !jogMode.value }
   Wire { from: "%surface%.shift"; to: "turntable.shift" }


    I updated my upload^^

  • djvic91
    djvic91 Member Posts: 69 Member
    Options

    Sûlherokhh please let me know if and when you do an update on the s4 mk3 screen where you can turn it on and off on the fly. Thanks 🙏

  • Sûlherokhh
    Sûlherokhh Member, Traktor Mapping Mod Posts: 1,818 mod
    edited February 29
    Options
    https://community.native-instruments.com/discussion/comment/136879#Comment_136879

    What happened? I cannot test your file, only read it. I don't own a Kontrol S3.

Back To Top

Categories