so I'm putting together this effect that decomposes a signal into partials via analytic filterbank pairs, with two different methods/sounds available - it can be used for pitch/frequency shift, chorus, flange, and other effects that aren't easily categorized. I think I have the bones of it put together, but I want to open it up to the folks here for feedback as to what implementations could be improved, features added, removed.
particularly I would be interested if somebody would be willing to help me refine the engine with some kind of strategy for smoothing out the sound when the controls are changed - I've tried a few different methods for this (one of which remains here in the 'voice shift logic' macro shortly before the output stage), but I haven't been able to get much discernible improvement. the control tweaks that produce the most clicks and pops are the 'f shift' and 'voice shift' knobs, the latter mainly when 'recomb' effect is turned on.
this is an experimental design & I'm willing to accept that some noise might be inevitable, but it'd be appreciated if someone could take a look & make any suggestions. I'd also like to combat the group delay to run engines 1 & 2 in tandem, but that's lower on the priority list for now.
